Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of CHANNEL_CONFIG_BLOCK in the Channel participation API tut… #2186

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

pamandrejko
Copy link
Contributor

Signed-off-by: pama-ibm pama@ibm.com

In the channel participation API tutorial I noticed a mismatch between the name of the genesis block that we generate and the name of the CHANNEL_CONFIG_BLOCK used by the osnadmin channel join command. This PR addresses the mismatch.

Type of change

  • Documentation update

Description

Existing doc generates the genesis block with this command and outputs the result to ./channel-artifacts/channel1.tx .
configtxgen -profile SampleAppGenesisEtcdRaft -outputBlock ./channel-artifacts/channel1.tx -channelID channel1

Then the subsequent step uses --config-block genesis_block.pb which won't work:

osnadmin channel join –-channel-id channel1 --config-block genesis_block.pb -o OSN1.example.com:7050 --ca-file $OSN_TLS_CA_ROOT_CERT --client-cert $ADMIN_TLS_SIGN_CERT --client-key $ADMIN_TLS_PRIVATE_KEY

After discussing with Will, we decide we should change the configtxgen command to be this instead:
configtxgen -profile SampleAppGenesisEtcdRaft -outputBlock genesis_block.pb -channelID channel1

…orial

Signed-off-by: pama-ibm <pama@ibm.com>
Copy link
Contributor

@wlahti wlahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Pam!

@wlahti wlahti merged commit 3b98a7b into hyperledger:master Dec 2, 2020
@wlahti
Copy link
Contributor

wlahti commented Dec 3, 2020

@Mergifyio backport release-2.3

mergify bot pushed a commit that referenced this pull request Dec 3, 2020
…orial (#2186)

Signed-off-by: pama-ibm <pama@ibm.com>
(cherry picked from commit 3b98a7b)
@mergify
Copy link

mergify bot commented Dec 3, 2020

Command backport release-2.3: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 3, 2020
…orial (#2186)

Signed-off-by: pama-ibm <pama@ibm.com>
(cherry picked from commit 3b98a7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants