platform/golang: loosen assertion for Go 1.16.2 #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages. Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
manish-sethi
approved these changes
Mar 15, 2021
|
@Mergifyio backport release-2.3 |
|
@Mergifyio backport release-2.2 |
|
Command
|
|
Command
|
denyeart
pushed a commit
to denyeart/fabric
that referenced
this pull request
Aug 31, 2021
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages. Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
denyeart
pushed a commit
to denyeart/fabric
that referenced
this pull request
Aug 31, 2021
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages. Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
manish-sethi
pushed a commit
that referenced
this pull request
Aug 31, 2021
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages. Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 24, 2022
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages. Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error messages for commands executed outside of a module were changed in Go 1.16.2. This change loosens our assertion to handle the old and new messages.