Adding block height check into orderer bootstrap #2594
Conversation
Param-S
force-pushed
the
skpemptylgrordererboot
branch
from
f11e603 to
a10f12c
Compare
Param-S
changed the title
|
Shouldn't we fix instead the core issue which is that the ledger creation for a channel isn't atomic? |
Param-S
force-pushed
the
skpemptylgrordererboot
branch
4 times, most recently
from
b310e5e to
733a542
Compare
|
/ci-run |
|
AZP build triggered! |
Param-S
force-pushed
the
skpemptylgrordererboot
branch
from
733a542 to
3bc096e
Compare
Param-S
changed the title
| @@ -113,16 +113,18 @@ type Registrar struct { | |||
| // ConfigBlock retrieves the last configuration block from the given ledger. | |||
| // Panics on failure. | |||
| func ConfigBlock(reader blockledger.Reader) *cb.Block { | |||
There was a problem hiding this comment.
Can you add a UT for this function?
There was a problem hiding this comment.
Yes, I will update the PR with UT
There was a problem hiding this comment.
The main intention of adding the UT was to cover the panic paths. Given that this function can take a mock as input, it should be straight forward to write this.
There was a problem hiding this comment.
Also, as you may want to make these changes into master as well. I'll suggest to brake these changes into two. One the original backporting PR as is and new changes in the master first.
There was a problem hiding this comment.
I corrected the UT now covering all error scenarios. Please check.
Should i need to create a separate PR for master branch?
There was a problem hiding this comment.
#2635 created a separate PR for main
Param-S
force-pushed
the
skpemptylgrordererboot
branch
from
553666c to
d75168c
Compare
Channel with empty ledger led to crash in 2.2 release Higher version added a check to skip the channels with empty ledger & continue to start up. The same changes backported. Signed-off-by: Parameswaran Selvam <parselva@in.ibm.com>
Param-S
force-pushed
the
skpemptylgrordererboot
branch
from
d75168c to
eeafb91
Compare
|
Opened different PRs. Closing this one |
Type of change
Description
Channel with empty ledger led to crash in 2.2 release
Higher version added a check to skip the channels with
empty ledger & continue to start up. The same changes
backported.
Updated GetBlock construct to retrieve the block by number
rather than using Iterator.
Signed-off-by: Parameswaran Selvam parselva@in.ibm.com