Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAB-18482 Unable to specify peer's chaincode.externalBuilders as an env variable #2643

Merged
merged 1 commit into from
Jun 30, 2021
Merged

FAB-18482 Unable to specify peer's chaincode.externalBuilders as an env variable #2643

merged 1 commit into from
Jun 30, 2021

Conversation

kopaygorodsky
Copy link
Contributor

@kopaygorodsky kopaygorodsky commented Jun 4, 2021 •
edited
Loading

Type of change

  • Bug fix

Description

As the HLF doc says, it's possible to override each config param via env variables, however, it isn't true for chaincode.externalBuilders

Also, added a small expectation to a test for chaincode.system configuration

Related issues

https://jira.hyperledger.org/browse/FAB-18482

@kopaygorodsky kopaygorodsky requested a review from a team as a code owner June 4, 2021 23:56
@kopaygorodsky kopaygorodsky changed the title FAB-18482 Unable to specify peer's chaincode.externalBuilders as env variable FAB-18482 Unable to specify peer's chaincode.externalBuilders as an env variable Jun 4, 2021
@kopaygorodsky
Added a possibility to override chaincode.externalBuilders via env va…
dd57d64 
…riable

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
davidkhala
davidkhala reviewed Jun 26, 2021
View reviewed changes
Copy link
Contributor

@davidkhala davidkhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, This is also what we need.

@davidkhala davidkhala mentioned this pull request Jun 26, 2021
Closed
@yacovm yacovm merged commit b5e0d27 into hyperledger:main Jun 30, 2021
@kopaygorodsky
Copy link
Contributor Author

thanks a lot!

@kopaygorodsky kopaygorodsky deleted the FAB-18482 branch June 30, 2021 22:06
@denyeart
Copy link
Contributor

I assume it would make sense to backport to release-2.2 and release-2.3?

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.3

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify mergify bot mentioned this pull request Jul 13, 2021
Merged
@mergify
Copy link

mergify bot commented Jul 13, 2021

Command backport release-2.3: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 13, 2021
@kopaygorodsky
Added a possibility to override chaincode.externalBuilders via env va…
fba5930 
…riable (#2643)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit b5e0d27)
mergify bot pushed a commit that referenced this pull request Jul 13, 2021
@kopaygorodsky
Added a possibility to override chaincode.externalBuilders via env va…
961373d 
…riable (#2643)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit b5e0d27)
@mergify mergify bot mentioned this pull request Jul 13, 2021
Closed
@mergify
Copy link

mergify bot commented Jul 13, 2021

Command backport release-2.2: success

Backports have been created

denyeart pushed a commit that referenced this pull request Jul 14, 2021
@kopaygorodsky @denyeart
Added a possibility to override chaincode.externalBuilders via env va…
90673b7 
…riable (#2643)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit b5e0d27)
@kopaygorodsky kopaygorodsky mentioned this pull request Sep 25, 2021
Closed
@kopaygorodsky kopaygorodsky mentioned this pull request Jul 19, 2022
Merged
C0rWin pushed a commit to C0rWin/fabric that referenced this pull request Sep 24, 2022
@kopaygorodsky @AllFi
Added a possibility to override chaincode.externalBuilders via env va…
bc17951 
…riable (hyperledger#2643)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit b5e0d27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkhala davidkhala davidkhala left review comments

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kopaygorodsky @denyeart @davidkhala @yacovm