Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-18521] Replicate block metadata with block while OSN catching up #2762

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

C0rWin
Copy link
Contributor

@C0rWin C0rWin commented Jul 17, 2021

While OSN catches up replicating block from the up-to-date replica, the metadata information omitted, i.e.

c.support.WriteBlock(block, nil)

Where nil substitutes for block's metadata. In this commit, the consenters metadata extracted from the replicated
block and is written with the block.

Signed-off-by: Artem Barger artem@bargr.net

@C0rWin C0rWin requested a review from a team as a code owner July 17, 2021 22:01
@C0rWin C0rWin requested review from yacovm and denyeart July 17, 2021 22:02
@C0rWin C0rWin force-pushed the portMetadataFix23 branch from b5eab6c to b2208f3 Compare July 18, 2021 12:52
While OSN catches up replicating block from the up-to-date replica the
metadata information omitted, i.e.

``
c.support.WriteBlock(block, nil)
``

where `nil` substitutes for block's metadata.

In this commit, the consenters metadata extracted from the replicated
block and being written with the block.

Signed-off-by: Artem Barger <artem@bargr.net>
@C0rWin C0rWin force-pushed the portMetadataFix23 branch from b2208f3 to 30a11e0 Compare July 18, 2021 12:55
@C0rWin
Copy link
Contributor Author

C0rWin commented Jul 18, 2021


goroutine 1822 [running]:
github.com/hyperledger/fabric/orderer/common/cluster_test.(*deliverServer).Deliver(0xc000b95640, 0x139daa0, 0xc00161e9f0, 0x0, 0x0)
	/home/vsts/work/1/fabric/orderer/common/cluster/deliver_test.go:188 +0x6a7
github.com/hyperledger/fabric-protos-go/orderer._AtomicBroadcast_Deliver_Handler(0x1219f40, 0xc000b95640, 0x139b1c0, 0xc00016cb40, 0x25cdb78, 0xc001d65000)
	/home/vsts/work/1/fabric/vendor/github.com/hyperledger/fabric-protos-go/orderer/ab.pb.go:724 +0xd0
google.golang.org/grpc.(*Server).processStreamingRPC(0xc00027e540, 0x139eb20, 0xc0004edc80, 0xc001d65000, 0xc0003b88a0, 0x1a87fa0, 0x0, 0x0, 0x0)
	/home/vsts/work/1/fabric/vendor/google.golang.org/grpc/server.go:1427 +0x1616
google.golang.org/grpc.(*Server).handleStream(0xc00027e540, 0x139eb20, 0xc0004edc80, 0xc001d65000, 0x0)
	/home/vsts/work/1/fabric/vendor/google.golang.org/grpc/server.go:1507 +0x138b
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc000137950, 0xc00027e540, 0x139eb20, 0xc0004edc80, 0xc001d65000)
	/home/vsts/work/1/fabric/vendor/google.golang.org/grpc/server.go:843 +0xdd
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/home/vsts/work/1/fabric/vendor/google.golang.org/grpc/server.go:841 +0x358
FAIL	github.com/hyperledger/fabric/orderer/common/cluster	84.195s

@yacovm yacovm merged commit b7463be into hyperledger:release-2.3 Jul 18, 2021
C0rWin added a commit to C0rWin/fabric that referenced this pull request Sep 24, 2022
…hyperledger#2762)

While OSN catches up replicating block from the up-to-date replica the
metadata information omitted, i.e.

``
c.support.WriteBlock(block, nil)
``

where `nil` substitutes for block's metadata.

In this commit, the consenters metadata extracted from the replicated
block and being written with the block.

Signed-off-by: Artem Barger <artem@bargr.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants