Update Go to v1.16.7 and alpine to 3.14 (release-2.3) #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denyeart
force-pushed
the
go1.16.7_2.3
branch
2 times, most recently
from
2ba6351 to
b83ca5a
Compare
denyeart
changed the title
yacovm
previously approved these changes
Aug 30, 2021
Update Go to v1.16.7. Go module support is assumed starting in Go v1.16. Therefore, for chaincodes without go modules (such as in the integration tests), need to explicitly set GO111MODULE to off otherwise chaincode will not compile. See Go v1.16 release notes for more details: https://golang.org/doc/go1.16#go-command As part of troubleshooting the Go upgrade, also added debug for the chaincode compile command. Also update alpine to 3.14. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
yacovm
approved these changes
Aug 31, 2021
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 24, 2022
* Clean up Go modules Run "go mod tidy" to clean up Go modules. Signed-off-by: David Enyeart <enyeart@us.ibm.com> * Update Go to v1.16.7 and alpine to 3.14 Update Go to v1.16.7. Go module support is assumed starting in Go v1.16. Therefore, for chaincodes without go modules (such as in the integration tests), need to explicitly set GO111MODULE to off otherwise chaincode will not compile. See Go v1.16 release notes for more details: https://golang.org/doc/go1.16#go-command As part of troubleshooting the Go upgrade, also added debug for the chaincode compile command. Also update alpine to 3.14. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Go to v1.16.7.
Go module support is assumed starting in Go v1.16.
Therefore, for chaincodes without go modules (such as in the integration tests),
need to explicitly set GO111MODULE to off otherwise chaincode will not compile.
See Go v1.16 release notes for more details: https://golang.org/doc/go1.16#go-command
As part of troubleshooting the Go upgrade, also added debug for the chaincode
compile command.
Also update alpine to 3.14.
Signed-off-by: David Enyeart enyeart@us.ibm.com