Update x509.CertPool equality checks (release-2.2) #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16 changed the CertPool implementation to employ functions to lazily acquire certificates. This change effectively breaks `reflect.DeepEqual` used by our test assertions. This commit changes the assertions compare certificate subjects instead of the entire pool. While not the same, it's a close approximation. See https://go-review.googlesource.com/c/go/+/229917 Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com> Signed-off-by: David Enyeart <enyeart@us.ibm.com>
denyeart
changed the title
yacovm
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16 changed the CertPool implementation to employ functions to
lazily acquire certificates. This change effectively breaks
reflect.DeepEqualused by our test assertions.This commit changes the assertions compare certificate subjects instead
of the entire pool. While not the same, it's a close approximation.
See https://go-review.googlesource.com/c/go/+/229917
Signed-off-by: Matthew Sykes sykesmat@us.ibm.com
Signed-off-by: David Enyeart enyeart@us.ibm.com