-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final peer for gateway #3091
Merged
Merged
Final peer for gateway #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Horton <joshh@us.ibm.com>
Signed-off-by: Josh Horton <joshh@us.ibm.com>
Signed-off-by: Josh Horton <joshh@us.ibm.com>
Signed-off-by: Josh Horton <joshh@us.ibm.com>
Closed
andrew-coleman
requested changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments
Signed-off-by: Josh Horton <joshh@us.ibm.com>
andrew-coleman
approved these changes
Dec 2, 2021
@Mergifyio backport release-2.4 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
* Peers for Gateway Signed-off-by: Josh Horton <joshh@us.ibm.com> * latest 11-29 review updates Signed-off-by: Josh Horton <joshh@us.ibm.com> * Final doc for peers topic Signed-off-by: Josh Horton <joshh@us.ibm.com> * final doc for peers gateway Signed-off-by: Josh Horton <joshh@us.ibm.com> * Andy final review Signed-off-by: Josh Horton <joshh@us.ibm.com> (cherry picked from commit 516bc8b)
✅ Backports have been created
|
andrew-coleman
pushed a commit
that referenced
this pull request
Dec 2, 2021
* Peers for Gateway Signed-off-by: Josh Horton <joshh@us.ibm.com> * latest 11-29 review updates Signed-off-by: Josh Horton <joshh@us.ibm.com> * Final doc for peers topic Signed-off-by: Josh Horton <joshh@us.ibm.com> * final doc for peers gateway Signed-off-by: Josh Horton <joshh@us.ibm.com> * Andy final review Signed-off-by: Josh Horton <joshh@us.ibm.com> (cherry picked from commit 516bc8b) Co-authored-by: Josh Horton <joshh@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peers topic for new gateway service, updates following WebEx with @andrew-coleman
Type of change
Description
gateway service running on peers in Fabric v2.4
Related issues
#2807