Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfreeze active nodes metrics once a consenter is evicted #3536

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Unfreeze active nodes metrics once a consenter is evicted #3536

merged 1 commit into from
Jul 20, 2022

Conversation

kopaygorodsky
Copy link
Contributor

Fixed active nodes metrics for etcdraft when a node is evicted. Instead of being frozen we set it to 0 once halt is called. Tests.

@kopaygorodsky kopaygorodsky requested a review from a team as a code owner July 20, 2022 12:26
@kopaygorodsky
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
32f4139 
…ad of being frozen we set it to 0 once halt is called. Tests.

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
@kopaygorodsky kopaygorodsky force-pushed the fix_metrics_active_nodes branch from d880bf3 to 32f4139 Compare July 20, 2022 12:36
@yacovm
Copy link
Contributor

yacovm commented Jul 20, 2022

code looks good, will re-run UTs

@yacovm yacovm enabled auto-merge (squash) July 20, 2022 13:24
@yacovm yacovm merged commit ba61a1b into hyperledger:main Jul 20, 2022
@kopaygorodsky
Copy link
Contributor Author

Do we want to backport this fix into 2.2 and 2.3?

@yacovm
Copy link
Contributor

yacovm commented Jul 20, 2022

Do we want to backport this fix into 2.2 and 2.3?

I don't know, doesn't seem anyone besides you noticed this :-)

@denyeart do we want this backported?

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.5

mergify bot pushed a commit that referenced this pull request Jul 26, 2022
@kopaygorodsky @mergify
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
68ffe42 
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit ba61a1b)
@mergify mergify bot mentioned this pull request Jul 26, 2022
Merged
@mergify
Copy link

mergify bot commented Jul 26, 2022

backport release-2.5

✅ Backports have been created

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.4

@denyeart
Copy link
Contributor

@Mergifyio backport release-2.2

@mergify mergify bot mentioned this pull request Jul 26, 2022
Merged
@mergify
Copy link

mergify bot commented Jul 26, 2022

backport release-2.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 26, 2022
@kopaygorodsky @mergify
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
e216096 
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit ba61a1b)
mergify bot pushed a commit that referenced this pull request Jul 26, 2022
@kopaygorodsky @mergify
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
9066f8f 
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit ba61a1b)

# Conflicts:
#	orderer/consensus/etcdraft/chain_test.go
@mergify mergify bot mentioned this pull request Jul 26, 2022
Closed
@mergify
Copy link

mergify bot commented Jul 26, 2022

backport release-2.2

✅ Backports have been created

@denyeart
Copy link
Contributor

Our policy now is to backport to in-flight releases (release-2.5), latest release (release-2.4), and latest LTS release (release-2.2) if somebody sees a need.
release-2.2 backport gave a conflict so it is up to the original PR opener to manually cherry-pick and resolve conflicts if they'd like it in that release.

denyeart pushed a commit that referenced this pull request Jul 26, 2022
@kopaygorodsky @denyeart
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
eaa807a 
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit ba61a1b)
denyeart pushed a commit that referenced this pull request Jul 26, 2022
@kopaygorodsky @denyeart
Fixed active nodes metrics for etcdraft when a node is evicted. Inste…
0d584c4 
…ad of being frozen we set it to 0 once halt is called. Tests. (#3536)

Signed-off-by: Vladyslav Kopaihorodskyi <vlad.kopaygorodsky@gmail.com>
(cherry picked from commit ba61a1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kopaygorodsky @yacovm @denyeart