Run a full external link for CGO against musl when building in Docker #3872
+129
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkneubuh
force-pushed
the
rel-2.5/bugfix/pkcs11
branch
from
3cc6da7 to
4105805
Compare
jkneubuh
force-pushed
the
rel-2.5/bugfix/pkcs11
branch
2 times, most recently
from
5df0432 to
5a222e4
Compare
Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
jkneubuh
force-pushed
the
rel-2.5/bugfix/pkcs11
branch
from
f37078e to
896eaa2
Compare
jkneubuh
changed the title
|
Closing this PR. Found another approach that covers all the bases correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com
Type of change
Description
This PR runs a full static link, at compile-time, for CGO against libmusl when building docker images. This is required for proper support of PKCS11 / HSM libraries, which require CGO.
Related issues