[FAB-17289] Fix gossip goroutine leak when reading msg #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shitaibin <hz_stb@163.com> Change-Id: I52acd1631b996ac44cd76a2f6c1319ae3a18cfb3
Shitaibin
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
yacovm
approved these changes
Dec 22, 2019
yacovm
pushed a commit
to yacovm/fabric
that referenced
this pull request
Dec 24, 2019
Signed-off-by: Shitaibin <hz_stb@163.com> Change-Id: I52acd1631b996ac44cd76a2f6c1319ae3a18cfb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
serviceConnectionnot notifyreadFromStreamto exit. It leads to memory leak. More evidence about memory leak described in FAB-17289.Related issues
FAB-17289