Bump github.com/containerd/containerd from 1.6.18 to 1.6.26 #4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denyeart
force-pushed
the
containerd_tools
branch
2 times, most recently
from
c0f2eb4 to
f244a5b
Compare
denyeart
force-pushed
the
containerd_tools
branch
from
f244a5b to
eed9fb7
Compare
denyeart
force-pushed
the
containerd_tools
branch
4 times, most recently
from
fe3a112 to
e6f80f6
Compare
pfi79
reviewed
Feb 5, 2024
| @@ -1643,7 +1643,8 @@ var _ = Describe("EndToEnd Smart BFT configuration test", func() { | |||
| // If backoff's default settings are left, it will take 20-25 seconds after the 7th attempt to reach the 8th attempt. | |||
| // If the backoff is made controllable, as here in the test, the maximum time between attempts will be 3 seconds. | |||
| for i := 0; i < 7; i++ { | |||
| Eventually(ordererRunners[0].Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("pickfirstBalancer: UpdateSubConnState.*IDLE connection error")) | |||
| // look for grpc Info message | |||
| Eventually(ordererRunners[0].Err(), network.EventuallyTimeout, time.Second).Should(gbytes.Say("Received SubConn state update.*IDLE connection error")) | |||
There was a problem hiding this comment.
Thank you. Relying on these log messages is fragile!
There was a problem hiding this comment.
Totally agree with you.
But I can't think of any other way to show and prove that there are problems with an unconfigured backoff grpc.
denyeart
force-pushed
the
containerd_tools
branch
from
e6f80f6 to
6368536
Compare
|
integration/gateway/gateway_bft_test.go line 183 on |
denyeart
force-pushed
the
containerd_tools
branch
from
6368536 to
0765112
Compare
Ah yes, hopefully this is the last one. |
pfi79
reviewed
Feb 5, 2024
| @@ -113,7 +113,7 @@ var _ = Describe("GatewayService with BFT ordering service", func() { | |||
| os.RemoveAll(testDir) | |||
| }) | |||
|
|
|||
| It("Submit transaction", func() { | |||
| FIt("Submit transaction", func() { | |||
There was a problem hiding this comment.
Maybe we should put `It' back in.
or
GINKGO_EDITOR_INTEGRATION=true before running focus test
There was a problem hiding this comment.
Ready to go now, thanks for the help!
Bump github.com/containerd/containerd from 1.6.18 to 1.6.26 Only move golang.org/x/tools to v0.14.0 (later versions introduce an issue with ./scripts/metrics_doc.sh check) Only move google.golang.org/protobuf to v1.31.0 (later versions introduce an issue with chaincode build) Update tests to reflect message updates in latest grpc v1.61.0. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
denyeart
force-pushed
the
containerd_tools
branch
from
0765112 to
8add17b
Compare
ale-linux
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump github.com/containerd/containerd from 1.6.18 to 1.6.26
Only move golang.org/x/tools to v0.14.0 (later versions introduce an issue with ./scripts/metrics_doc.sh check)
Only move google.golang.org/protobuf to v1.31.0 (later versions introduce an issue with chaincode build)
Update tests to reflect message updates in latest grpc v1.61.0.