Skip to content

refactor: omit unnecessary reassignment #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

refactor: omit unnecessary reassignment #5296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion orderer/common/cluster/clusterservice_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,6 @@ func TestClusterRequestAsString(t *testing.T) {
}

for _, tc := range tcs {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
retVal := cluster.ClusterRequestAsString(tc.input)
Expand Down
2 changes: 0 additions & 2 deletions orderer/common/cluster/comm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,6 @@ func TestAbortRPC(t *testing.T) {
}

for _, testCase := range testCases {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
testAbort(t, testCase.abortFunc, testCase.rpcTimeout, testCase.expectedErr)
})
Expand Down Expand Up @@ -1377,7 +1376,6 @@ func TestMetrics(t *testing.T) {
},
},
} {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
fakeProvider := &mocks.MetricsProvider{}
testCase.testMetrics = &testMetrics{
Expand Down
1 change: 0 additions & 1 deletion orderer/common/cluster/commauth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,6 @@ func TestBuildStepRespone(t *testing.T) {
},
}
for _, tc := range tcs {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
res, err := cluster.BuildStepRespone(tc.input)
Expand Down
2 changes: 0 additions & 2 deletions orderer/common/cluster/deliver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,6 @@ func TestBlockPullerFailures(t *testing.T) {
failFunc: malformBlockSignatureAndRecreateOSNBuffer,
},
} {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
testLogger.Infof("Starting test case: %s", testCase.name)
osn := newClusterNode(t)
Expand Down Expand Up @@ -1130,7 +1129,6 @@ func TestBlockPullerBadBlocks(t *testing.T) {
}

for _, testCase := range testcases {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
osn := newClusterNode(t)
defer osn.stop()
Expand Down
1 change: 0 additions & 1 deletion orderer/common/cluster/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ func TestSubmitFailure(t *testing.T) {
}

for _, testCase := range testCases {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
dispatcher := &mocks.Dispatcher{}
stream := &mocks.StepStream{}
Expand Down
4 changes: 0 additions & 4 deletions orderer/common/cluster/util_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ func TestVerifyBlockHash(t *testing.T) {
},
},
} {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
blockchain := createBlockChain(start, end)
blockchain = testCase.mutateBlockSequence(blockchain)
Expand Down Expand Up @@ -693,7 +692,6 @@ func TestLastConfigBlock(t *testing.T) {
blockRetriever: blockRetriever,
},
} {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
block, err := cluster.LastConfigBlock(testCase.block, testCase.blockRetriever)
if testCase.expectedError == "" {
Expand Down Expand Up @@ -1267,7 +1265,6 @@ func TestCompareCertPublicKeysErrorHandling(t *testing.T) {
}

for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -1325,7 +1322,6 @@ func TestCompareCertPublicKeysWithMalformedCertificates(t *testing.T) {
}

for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

Expand Down
1 change: 0 additions & 1 deletion orderer/consensus/etcdraft/eviction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ func TestEvictionSuspector(t *testing.T) {
},
},
} {
testCase := testCase
t.Run(testCase.description, func(t *testing.T) {
committedBlocks := make(chan *common.Block, 2)

Expand Down
1 change: 0 additions & 1 deletion orderer/consensus/smartbft/configverifier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ func TestValidateConfig(t *testing.T) {
expectedError: "error proposing config update",
},
} {
testCase := testCase
t.Run(testCase.name, func(t *testing.T) {
cup := &mocks.ConfigUpdateProposer{}
f := &mocks.Filters{}
Expand Down