Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msp.rst #691

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Update msp.rst #691

merged 2 commits into from
Mar 3, 2020

Conversation

chintanr97
Copy link
Contributor

I learnt that Hyperledger Fabric does not provide custom OU support in profile section. But the documentation at https://hyperledger-fabric.readthedocs.io/en/master/msp.html#best-practices suggests in point number 2.1 that we can define policies which capture the custom OUs of the identity.

Signed-off-by: Chintan Rajvir chintanr97@gmail.com

Type of change

  • Bug fix
  • New feature
  • Improvement (improvement to code, performance, etc)
  • Test update
  • Documentation update

Description

Additional details

Related issues

I learnt that Hyperledger Fabric does not provide custom OU support in profile section. But the documentation at https://hyperledger-fabric.readthedocs.io/en/master/msp.html#best-practices suggests in point number 2.1 that we can define policies which capture the custom OUs of the identity.

Signed-off-by: Chintan Rajvir <chintanr97@gmail.com>
@chintanr97 chintanr97 requested review from a team as code owners February 19, 2020 05:52
docs/source/msp.rst Outdated Show resolved Hide resolved
docs/source/msp.rst Outdated Show resolved Hide resolved
@chintanr97 chintanr97 requested a review from jyellick February 21, 2020 05:15
Signed-off-by: Chintan Rajvir <chintanr97@gmail.com>
Copy link
Contributor

@pamandrejko pamandrejko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chintanr97 chintanr97 requested review from jyellick and removed request for jyellick February 25, 2020 15:34
@chintanr97
Copy link
Contributor Author

LGTM

@pamandrejko Need one more approval!

@pamandrejko
Copy link
Contributor

@btl5037 Since we only require a single +1 here, what is preventing this from being merged? Jason's comments are marked resolved.

@chintanr97
Copy link
Contributor Author

chintanr97 commented Feb 28, 2020

@btl5037 Since we only require a single +1 here, what is preventing this from being merged? Jason's comments are marked resolved.

@pamandrejko It says:

"1 review requesting changes and 1 approving review by reviewers with write access." I did not understand this!

@jyellick jyellick merged commit a90767c into hyperledger:master Mar 3, 2020
@chintanr97 chintanr97 deleted the patch-2 branch May 6, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants