[FAB-16297] Remove pvtdataStore initiation with non-zero block height #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove functions that set the initial state for the pvtdata store when an existing block store has a blockchain but the pvtdata store is empty. This situation is expected to happen when a peer is upgraded directly from version 1.0 to a future version (i.e., 1.0+), and an existing blockchain is present (which was created with version 1.0). Under this scenario, the pvtdata store is brought upto the point as if it has processed existing blocks with no pvtdata. As we don't expect/support a direct upgrade from version 1.0 to version 2.1, we can remove code that takes care of the above mentioned scenario.. Note that pvt data feature is available since version 1.1 (experimental) and became stable in version 1.2 Signed-off-by: senthil <cendhu@gmail.com>
cendhu
force-pushed
the
rm-pvtstore-init
branch
from
e3ec89e to
4c7e0bf
Compare
C0rWin
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR removes functions that set the initial state for the pvtdata store when an existing block store has a blockchain but the pvtdata store is empty. This situation is expected to happen when a peer is upgraded directly from version 1.0 to a future version (i.e., 1.0+), and an existing blockchain is present (which was created with version 1.0). Under this scenario, the pvtdata store is brought up to the point as if it has processed existing blocks with no pvtdata.
As we don't expect/support a direct upgrade from version 1.0 to version 2.1, we can remove code that takes care of the above-mentioned scenario.
Additional details
Note that pvtdata feature is available since version 1.1 (experimental) and became stable in version 1.2.
Related issues
FAB-16297
Release Note
Do we need to mention in the release note of v2.1 that the user cannot directly upgrade from version 1.0 to version 2.1?