Fix nil dereference in etcdraft config parsing #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The etcdraft config parsing code currently checks that the consensus metadata is not nil, but it fails to check that the options are not nil. This commit simply adds the additional check and backfills some testing around this validation function. Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
yacovm
approved these changes
Feb 24, 2020
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 15, 2020
The etcdraft config parsing code currently checks that the consensus metadata is not nil, but it fails to check that the options are not nil. This commit simply adds the additional check and backfills some testing around this validation function. Signed-off-by: Jason Yellick <jyellick@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The etcdraft config parsing code currently checks that the consensus
metadata is not nil, but it fails to check that the options are not nil.
This commit simply adds the additional check and backfills some testing
around this validation function.