Revert "[FAB-17438] CA deployment guide" #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original PR merged by mistake. |
joealewine
previously approved these changes
Feb 27, 2020
|
Need DCO, and I need to figure out how that got merged |
|
Since I made a correction to Pam’s PR, it gave me the option to commit the suggestion from the reviewer workflow. Because I committed from there and not with a separate PR, it failed the DCO check. When I clicked on the DCO fail ‘details’ link, it gave me the option to manually set the DCO check to ‘passed’ and continue to merge.
…Sent from my iPhone
On Feb 27, 2020, at 7:48 AM, Brett Logan ***@***.***> wrote:
Need DCO, and I need to figure out how that got merged
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This reverts commit 04d3bf2. Signed-off-by: pama-ibm <pama@ibm.com>
pamandrejko
force-pushed
the
revert-751-FAB-17438-new
branch
from
50f1177 to
da22abc
Compare
joealewine
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #751