Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error from multiple lines removed. #8

Closed
wants to merge 1 commit into from
Closed

Error from multiple lines removed. #8

wants to merge 1 commit into from

Conversation

iamsaurabhc
Copy link

Description

go vet ./orderer/... was giving error of Following:
Makefile:107: recipe for target 'linter' failed
After exit status 1.
This happened mainly because structure is defined with a name Status, which was not used while calling it. Thus generating an error. I've attached the error
capture

Motivation and Context

After the change, if run smoothly.

Fixes #

How Has This Been Tested?

Checklist:

  • [] I have added a Signed-off-by.
  • [] I have either added documentation to cover my changes or this change requires no new documentation.
  • [] I have either added unit tests to cover my changes or this change requires no new tests.
  • [] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by:

Error was : composite literal uses unkeyed fields

Error was : composite literal uses unkeyed fields
@christo4ferris
Copy link
Contributor

@iamsaurabhc Thanks for submitting this PR. We use Gerrit for considering pull requests. Would you please re-submit using the instructions here. Thanks!

@ghost
Copy link

ghost commented Nov 6, 2016

you would need to check out the repo here: https://gerrit.hyperledger.org/r/#/admin/projects/fabric and make your edits, pushing them to gerrit

here is a walkthrough for zephyrproject which is much the same WRT setting up an LFID, adding ssh keys, etc:
https://www.zephyrproject.org/doc/1.1.0/collaboration/code/gerrit_accounts.html

feel free to ask on slack - https://slack.hyperledgerproject.org/ - I'm @ry there, feel free to ask me directly, or discuss in #fabric

one note: when you set up your LFID do not use social logins the first time, create the account and you can add social logins later

@ghost ghost closed this Nov 6, 2016
andrew-coleman pushed a commit to andrew-coleman/fabric that referenced this pull request Jun 23, 2022
TonyWu3027 added a commit to alfredomusumeci/fabric that referenced this pull request Aug 16, 2023
TonyWu3027 added a commit to alfredomusumeci/fabric that referenced this pull request Aug 16, 2023
Implement BSCC protoutil

Signed-off-by: Tony Wu <tony.wu122@imperial.ac.uk>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants