Fix data race in TestBlockingEnqueue #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some tests we need to overwrite the mocks.Mock field of the mock, however it could be that it is used concurrently by other goroutines. We use a lock to ensure mutual exclusion and memory cohesion, and the mock methods lock before calling the mocked method. The lock was only used upon demand and not consistently. I made the lock to be always activated. Change-Id: Iffd02f681b144d2456640922c4c5a6438109a40e Signed-off-by: yacovm <yacovm@il.ibm.com>
C0rWin
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests we need to overwrite the mocks.Mock field
of the mock, however it could be that it is used concurrently
by other goroutines.
We use a lock to ensure mutual exclusion and memory cohesion,
and the mock methods lock before calling the mocked method.
The lock was only used upon demand and not consistently.
I made the lock to be always activated.
Change-Id: Iffd02f681b144d2456640922c4c5a6438109a40e
Signed-off-by: yacovm yacovm@il.ibm.com