[FAB-17591] Support adding an orderer endpoint to existing config #857
Conversation
wuxuer
force-pushed
the
FAB-17591
branch
3 times, most recently
from
eeb29d0 to
a8ee77b
Compare
pkg/config/orderer.go
Outdated
|
|
||
| existingOrdererEndpoints = append(existingOrdererEndpoints, endpoint) | ||
|
|
||
| // Add anchor peers config value back to application org |
There was a problem hiding this comment.
Add orderer endpoints config value back to orderer org
There was a problem hiding this comment.
Yeah, I will fix it.
|
@hellosmallstone can you also update the example_test update config scenario to reflect adding an orderer endpoint? Thanks! |
OK, I will update it. |
Description Modify an existing channel configuration to add an orderer endpoint to an orderer org's config group. Related issues https://jira.hyperledger.org/browse/FAB-17591 Signed-off-by: xu wu <wuxu1103@163.com>
|
@caod123 Hi, I have updated the example_test. Please review it, thx. |
|
LGTM +1 |
| @@ -284,3 +284,40 @@ func addOrdererPolicies(cg *cb.ConfigGroup, policyMap map[string]Policy, modPoli | |||
|
|
|||
| return addPolicies(cg, policyMap, modPolicy) | |||
| } | |||
|
|
|||
| // AddOrdererEndpoints adds an orderer's endpoint to an existing channel config transaction. | |||
There was a problem hiding this comment.
AddOrdererEndpoint vs AddOrdererEndpoints - the Doc name doesn't match the function name.
There was a problem hiding this comment.
Sorry about it.
I fixed the two nits in #891.
| if ordererAddrConfigValue, ok := ordererOrgGroup.Values[EndpointsKey]; ok { | ||
| err := proto.Unmarshal(ordererAddrConfigValue.Value, ordererAddrProto) | ||
| if err != nil { | ||
| return fmt.Errorf("failed unmarshalling orderer org %s's endpoints: %v", orgName, err) |
There was a problem hiding this comment.
two spaces in the message instead of one and we can omit the possessive.
Description Fix nits in function AddOrdererEndpoint which were imported by hyperledger#857. Signed-off-by: xu wu <wuxu1103@163.com>
Description Fix nits in function AddOrdererEndpoint which were imported by #857. Signed-off-by: xu wu <wuxu1103@163.com>
Description
Modify an existing channel configuration to add an orderer endpoint to an orderer org's config group.
Related issues
https://jira.hyperledger.org/browse/FAB-17591
Signed-off-by: xu wu wuxu1103@163.com
Type of change
Description
Additional details
Related issues