[FAB-17624] Handle net.Listen error in gossip unit test #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function createDiscoveryInstanceThatGossipsWithInterceptors attempts to create a net.Listener which binds on an address, and it can fail if the port is in use. The code currently just prints the error and continues, and later on panics with a nil pointer. I changed the code so that it now panics and doesn't continue the flow of the test. Change-Id: Ie55317a79d8fab03ab2f64d1e4a016cc416397ee Signed-off-by: yacovm <yacovm@il.ibm.com>
C0rWin
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function createDiscoveryInstanceThatGossipsWithInterceptors attempts
to create a net.Listener which binds on an address, and it can fail
if the port is in use.
The code currently just prints the error and continues, and later on
panics with a nil pointer.
I changed the code so that it now panics and doesn't continue the flow
of the test.
Change-Id: Ie55317a79d8fab03ab2f64d1e4a016cc416397ee
Signed-off-by: yacovm yacovm@il.ibm.com