Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17611] IT: discover all peers before endorsement #895

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

wenjianqiao
Copy link
Contributor

@wenjianqiao wenjianqiao commented Mar 20, 2020

Signed-off-by: Wenjian Qiao wenjianq@gmail.com

Type of change

  • Test update

Description

To mitigate a test flake with private data dissemination,
this PR adds code to discover all the peers to ensure that
the gossip service has been successfully initialized.

Related issues

https://jira.hyperledger.org/browse/FAB-17611

@wenjianqiao wenjianqiao requested a review from a team as a code owner March 20, 2020 17:27
@wenjianqiao wenjianqiao changed the title [FAB-17611] IT: check all peers are discovered before endorsement WIP [FAB-17611] IT: discover all peers before endorsement Mar 20, 2020
@wenjianqiao
Copy link
Contributor Author

/ci-run

@github-actions
Copy link

AZP build triggered!

@wenjianqiao
Copy link
Contributor Author

/ci-run

@github-actions
Copy link

AZP build triggered!

@wenjianqiao wenjianqiao force-pushed the fab17611 branch 4 times, most recently from b83a10a to 4e64b7d Compare March 26, 2020 16:42
@wenjianqiao
Copy link
Contributor Author

gossip UT flake

@wenjianqiao
Copy link
Contributor Author

/ci-run

@github-actions
Copy link

AZP build triggered!

@wenjianqiao wenjianqiao force-pushed the fab17611 branch 4 times, most recently from 3babea4 to 06cde9a Compare March 27, 2020 03:14
@wenjianqiao wenjianqiao force-pushed the fab17611 branch 2 times, most recently from 66cda7a to 1cc4cf8 Compare March 28, 2020 02:28
@wenjianqiao wenjianqiao changed the title WIP [FAB-17611] IT: discover all peers before endorsement [FAB-17611] IT: discover all peers before endorsement Mar 28, 2020
To mitigate a test flake with private data dissemination,
this PR adds code to discover all the peers to ensure that
the gossip service has been successfully initialized.

Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
Copy link
Contributor

@mastersingh24 mastersingh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ... let's hope this does the trick

@mastersingh24 mastersingh24 merged commit b8e2e83 into hyperledger:master Mar 29, 2020
@wenjianqiao wenjianqiao deleted the fab17611 branch April 9, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants