-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAB-17611] IT: discover all peers before endorsement #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjianqiao
changed the title
[FAB-17611] IT: check all peers are discovered before endorsement
WIP [FAB-17611] IT: discover all peers before endorsement
Mar 20, 2020
/ci-run |
AZP build triggered! |
/ci-run |
AZP build triggered! |
wenjianqiao
force-pushed
the
fab17611
branch
4 times, most recently
from
March 26, 2020 16:42
b83a10a
to
4e64b7d
Compare
gossip UT flake |
/ci-run |
AZP build triggered! |
wenjianqiao
force-pushed
the
fab17611
branch
4 times, most recently
from
March 27, 2020 03:14
3babea4
to
06cde9a
Compare
wenjianqiao
force-pushed
the
fab17611
branch
2 times, most recently
from
March 28, 2020 02:28
66cda7a
to
1cc4cf8
Compare
wenjianqiao
changed the title
WIP [FAB-17611] IT: discover all peers before endorsement
[FAB-17611] IT: discover all peers before endorsement
Mar 28, 2020
cendhu
reviewed
Mar 28, 2020
To mitigate a test flake with private data dissemination, this PR adds code to discover all the peers to ensure that the gossip service has been successfully initialized. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
Merged
mastersingh24
approved these changes
Mar 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ... let's hope this does the trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
To mitigate a test flake with private data dissemination,
this PR adds code to discover all the peers to ensure that
the gossip service has been successfully initialized.
Related issues
https://jira.hyperledger.org/browse/FAB-17611