feat: Add mTLS configuration for ffresty #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enriquelacal@Enriques-MacBook-Pro.local>
EnriqueL8
requested review from
peterbroadhurst,
nguyer and
awrichar
as code owners
peterbroadhurst
requested changes
Apr 19, 2023
There was a problem hiding this comment.
This is great @EnriqueL8 - A few suggestions/questions to consider.
|
|
||
| var client *resty.Client | ||
|
|
||
| func New(ctx context.Context, staticConfig config.Section) (client *resty.Client, err error) { |
There was a problem hiding this comment.
As you mention, this line will drive a lot of change in the components.
I wonder if the right answer here, is to prepare a set of PRs against the other hyperledger/firefly-* repositories - otherwise they would become unable to pick up security maintenance.
There was a problem hiding this comment.
Sounds like a plan, have already started on the main firefly but will look at the other repos and coordinate the changes
added 3 commits
April 20, 2023 13:23
Signed-off-by: Enrique Lacal <enriquelacal@Enriques-MacBook-Pro.local>
Signed-off-by: Enrique Lacal <enriquelacal@Enriques-MacBook-Pro.local>
EnriqueL8
force-pushed
the
add_mtls_ffresty
branch
from
f5604d7
to
d9fb901
Compare
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
EnriqueL8
force-pushed
the
add_mtls_ffresty
branch
from
d9fb901
to
089551f
Compare
This was referenced Apr 20, 2023
EnriqueL8
commented
Apr 21, 2023
peterbroadhurst
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Awesome. Thanks for going the extra mile to package this one all up so tidily @EnriqueL8!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to supply a config to the ffresty client to setup TLS and mTLS.
NOTE This changes the interface of that init function to now return an error as well, so every consumer of this library and that client on update will need to handle that error. We could avoid doing this by allowing the user to provide a TLS Config as an argument but the pattern seems to be to provide viper config!
For testing I added a series of real and fake certificates and keys. I also explore standing up an mTLS mock server with the
httptestbut it proved cumbersome. I think validating that the correct certificates are added to the TLS Config should be good enough but happy to rectify