Increase handling of JSON Number large numbers (vs. string) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
…e-json-number-support
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
EnriqueL8
reviewed
Aug 28, 2024
|
Thanks for covering these cases that I didn't in the original PR @peterbroadhurst. They look good to me with the exception of @EnriqueL8 's comment. I'll leave him to approve it once that comment has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #76 to cover some additional important cases where consumers of this library use types that need to support:
The code does cause errors in some previously ignored scenarios that would result in bad numbers:
HexUint64from a number larger than18446744073709551615HexUint64from a fractional number like1.2345