Pass through full structure of receipt events for detailed reporting #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
requested review from
awrichar,
nguyer and
dechdev
as code owners
dechdev
approved these changes
Aug 10, 2022
I'm not sure this is something we're trying to preserve. It may already be broken for all I know (we certainly don't test that combination). I would personally vote to change the format completely and drop legacy fields. We specifically have a Also, these changes will need to be duplicated to erc1155. |
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With EVMConnect we pass through lots of really important information in the updates to a transaction (aka "replies" or "receipts" on the WebSocket), as it's being shepherded through nonce/gas management, and confirmations, to a blockchain (public, or private).
The ERC20/ERC721 connector is currently masking all this info, and turning it into a binary
success: true+messagefield, which has two problems:operationTransactionUpdategets interpreted asFailure, rather than just an informational update that leaves the operation inPendingThis PR tries to preserve the existing fields, so that the new tokens connector can still be used with FireFly V1.0 + EthConnect, as well as FireFly V1.1 + EthConnect or EVMConnect