Remove the websocket.topic for simplicity and to avoid undefined behavior #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
|
For the record, the change in the Ethereum plugin in core was here: hyperledger/firefly#999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention during EVMConnect was to remove this field, because the behavior around it in EthConnect was confusing.
However, we thought that compatibility/migration in FireFly Core and the ERC-20/ERC-721 and ERC-1155 token connectors would be a pain. So we put it back in...
We've since worked through all that in the tokens thanks to @awrichar in the following PRs, so this PR pulls it back out again: