Merge pull request #953 from kaleido-io/missingdata

Distinguish "message not available" from "message missing data"
hyperledger · Aug 10, 2022 · 5ede657 · 5ede657
2 parents a5b068c + e820054
commit 5ede657
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/internal/events/aggregator.go b/internal/events/aggregator.go
@@ -421,10 +421,13 @@ func (ag *aggregator) processMessage(ctx context.Context, manifest *core.BatchMa
 		cro = data.CRORequirePublicBlobRefs
 	}
 	msg, data, dataAvailable, err := ag.data.GetMessageWithDataCached(ctx, msgEntry.ID, cro)
-	if err != nil {
+	switch {
+	case err != nil:
 		return err
-	}
-	if !dataAvailable {
+	case msg == nil:
+		l.Debugf("Message '%s' in batch '%s' is not yet available", msgEntry.ID, manifest.ID)
+		return nil
+	case !dataAvailable:
 		l.Errorf("Message '%s' in batch '%s' is missing data", msgEntry.ID, manifest.ID)
 		return nil
 	}

diff --git a/internal/events/aggregator_test.go b/internal/events/aggregator_test.go
@@ -938,6 +938,19 @@ func TestProcessMsgFailData(t *testing.T) {
 	mdm.AssertExpectations(t)
 }
 
+func TestProcessMsgNoData(t *testing.T) {
+	ag, cancel := newTestAggregator()
+	defer cancel()
+
+	mdm := ag.data.(*datamocks.Manager)
+	mdm.On("GetMessageWithDataCached", ag.ctx, mock.Anything, data.CRORequirePins).Return(nil, nil, false, nil)
+
+	err := ag.processMessage(ag.ctx, &core.BatchManifest{}, &core.Pin{Masked: true, Sequence: 12345}, 10, &core.MessageManifestEntry{}, nil)
+	assert.NoError(t, err)
+
+	mdm.AssertExpectations(t)
+}
+
 func TestProcessMsgFailMissingData(t *testing.T) {
 	ag, cancel := newTestAggregator()
 	defer cancel()