-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status information for subscriptions & contract listeners #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6553576
to
609f587
Compare
This was referenced Aug 31, 2022
Merged
If supported by the blockchain connector, GET `/contracts/listeners/:id` will return additional status information about the underlying subscription. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Providing the `fetchstatus` query parameter will add offset information, if available, to the subscription response. Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
609f587
to
d20f34f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 302 302
Lines 19919 19956 +37
=======================================
+ Hits 19917 19954 +37
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
ef2adf3
to
087d1a8
Compare
peterbroadhurst
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those extra changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
fetchstatus
query param is supplied when queryingsubscriptions
orlisteners
by ID, firefly will return additional status information, if it is available.Contract listeners:
FF environments connected to evm connectors will return listener checkpoint formation under the
status
key.Example query:
http://localhost:5000/api/v1/namespaces/default/contracts/listeners/92e3bc0c-3c3f-455b-81d3-4124a0270b1d?fetchstatus
Response:
Subscriptions
Subscriptions will provide offset information if available
Example Query:
http://localhost:5000/api/v1/namespaces/default/subscriptions/32cddc74-cc1a-4493-b376-45781e2d8d35?fetchstatus
Response: