Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make contract listener location optional #1068

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

shorsher
Copy link
Member

closes #1066

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #1068 (c082502) into main (1f31807) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         307      307           
  Lines       20294    20301    +7     
=======================================
+ Hits        20292    20299    +7     
  Misses          2        2           
Impacted Files Coverage Δ
internal/blockchain/ethereum/ethereum.go 100.00% <100.00%> (ø)
internal/blockchain/ethereum/eventstream.go 100.00% <100.00%> (ø)
internal/blockchain/fabric/eventstream.go 100.00% <100.00%> (ø)
internal/blockchain/fabric/fabric.go 100.00% <100.00%> (ø)
internal/contracts/manager.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shorsher
Copy link
Member Author

shorsher commented Sep 22, 2022

Need to do a quick change to how Fabric handles location, so moving this to draft.

@shorsher shorsher marked this pull request as draft September 22, 2022 18:51
@shorsher shorsher marked this pull request as ready for review September 22, 2022 23:30
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher merged commit 975d4b7 into hyperledger:main Sep 22, 2022
@shorsher shorsher deleted the event-sig-listener branch September 22, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow contract listeners to be created without location
3 participants