Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operations to change between "Failed" and "Succeeded" #1265

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Apr 7, 2023

Fixes #1264
Follow-up to #1257

Operations now cannot move from Failed/Succeeded back to Pending, but they can change between Failed and Succeeded.

Fixes hyperledger#1264
Follow-up to hyperledger#1257

Operations now cannot move from Failed/Succeeded back to Pending, but they
can change between Failed and Succeeded.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@22bde98). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage        ?   99.99%           
=======================================
  Files           ?      308           
  Lines           ?    20557           
  Branches        ?        0           
=======================================
  Hits            ?    20555           
  Misses          ?        1           
  Partials        ?        1           
Impacted Files Coverage Δ
internal/operations/operation_updater.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shorsher shorsher merged commit 491e160 into hyperledger:main Apr 7, 2023
@shorsher shorsher deleted the replaceop branch April 7, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation that is retried many times may change from "Failed" to "Succeeded"
3 participants