Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates prior to adding unique index on contract API ID #1293

Merged
merged 1 commit into from
May 2, 2023

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Apr 28, 2023

Also ensure ID is always unset when creating a new API.

Follow-up to #1292, #1275

Also ensure ID is always unset when creating a new API.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1293 (c95e765) into main (e239a5c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          308       308           
  Lines        20671     20672    +1     
=========================================
+ Hits         20671     20672    +1     
Impacted Files Coverage Δ
internal/apiserver/route_post_new_contract_api.go 100.00% <100.00%> (ø)

@awrichar awrichar merged commit 7802237 into hyperledger:main May 2, 2023
@awrichar awrichar deleted the api-id branch May 2, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants