-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry tokens events consistent with FFDX, as we cannot push back nack #1296
Conversation
… to tokens connector Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 308 308
Lines 20678 20692 +14
=========================================
+ Hits 20678 20692 +14
|
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@@ -346,12 +354,15 @@ func (ft *FFTokens) handleTokenPoolCreate(ctx context.Context, data fftypes.JSON | |||
blockchainEvent := data.GetObject("blockchain") | |||
|
|||
poolDataString := data.GetString("data") | |||
if poolData == nil && poolDataString != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In unit testing, I found the poolData == nil && poolDataString == ""
case was uncaught, and resulted in a panic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1121? 🙏
Diagnosing whether this test failure is related to the code change
|
#1296 (comment) appears unrelated to the change, but does need diagnosis. Raised #1297 |
Fixes #1121 |
Make this consistent with what we did for FFDX, and prevents a scenario on startup as seen in the integration test where a token event comes in before the namespace is started:
Also made a change to both FFDX and FFTokens to split
eventRetry
out fromretry
in the config, as I realized looking at this PR that the config was overlapping with theffresty
config for request retry.