Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token pools from the cache upon deletion #1356

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

awrichar
Copy link
Contributor

Fixes #1355

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengxuan
Copy link
Contributor

Does look like we are repeating logic in the firely-common library. Will raise a PR to fix this outstanding debt.

Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1356 (7615c29) into main (a1a47d1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7615c29 differs from pull request most recent head ce08f5c. Consider uploading reports for the commit ce08f5c to get more accurate results

@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
- Coverage   99.99%   99.99%   -0.01%     
==========================================
  Files         314      314              
  Lines       21537    21500      -37     
==========================================
- Hits        21535    21498      -37     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
internal/assets/token_pool.go 100.00% <100.00%> (ø)
internal/cache/cache.go 100.00% <100.00%> (ø)

@Chengxuan
Copy link
Contributor

@awrichar @matthew1001 PR raised to move to common lib kaleido-io#71

@awrichar awrichar merged commit 63501a5 into hyperledger:main Jun 29, 2023
@awrichar awrichar deleted the pool-cache branch June 29, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token pools are not removed from cache when deleted
5 participants