-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove token pools from the cache upon deletion #1356
Conversation
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does look like we are repeating logic in the firely-common library. Will raise a PR to fix this outstanding debt. |
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1356 +/- ##
==========================================
- Coverage 99.99% 99.99% -0.01%
==========================================
Files 314 314
Lines 21537 21500 -37
==========================================
- Hits 21535 21498 -37
Misses 1 1
Partials 1 1
|
@awrichar @matthew1001 PR raised to move to common lib kaleido-io#71 |
move to use the common lib
Fixes #1355