v1.2: fix: multiple named tuple result from contract #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
This reverts commit 812ea5b. Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
nguyer
reviewed
Jul 11, 2023
internal/apiserver/server.go
Outdated
| @@ -66,7 +66,7 @@ type apiServer struct { | |||
| func InitConfig() { | |||
| httpserver.InitHTTPConfig(apiConfig, 5000) | |||
| httpserver.InitHTTPConfig(spiConfig, 5001) | |||
| httpserver.InitHTTPConfig(metricsConfig, 6000) | |||
| httpserver.InitHTTPConfig(metricsConfig, 7000) | |||
There was a problem hiding this comment.
I'm not sure that we want to change the default metrics port in a patch release. Was there a reason for this change?
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## release-1.2 #1365 +/- ##
===============================================
- Coverage 100.00% 99.98% -0.02%
===============================================
Files 305 305
Lines 20027 20040 +13
===============================================
+ Hits 20027 20036 +9
- Misses 0 3 +3
- Partials 0 1 +1
|
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1333