Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build tag in release GitHub action #1480

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Mar 15, 2024

In testing v1.3.0-rc.1 I noticed an issue with the version information. This resulted in the wrong version being displayed:

  • When the application starts up, in its log file
  • In the Docker image labels

An example of an incorrectly labeled image is here: https://github.com/hyperledger/firefly/pkgs/container/firefly/186598190?tag=v1.3.0-rc.1

Despite the label being incorrect on this image, the tag was correct. This PR sets them to the same thing.

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer requested a review from a team as a code owner March 15, 2024 19:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (577e8c4) to head (e351d86).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         322      322           
  Lines       23406    23406           
=======================================
  Hits        23404    23404           
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nguyer nguyer merged commit 23af4de into hyperledger:main Mar 22, 2024
15 checks passed
@nguyer nguyer deleted the fix-docker-release-job branch March 22, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants