-
Notifications
You must be signed in to change notification settings - Fork 241
Add eyecatcher log lines at info-level for transaction lifecycle #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 342 342
Lines 25015 25022 +7
=======================================
+ Hits 25007 25014 +7
Misses 4 4
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterbroadhurst - this is useful!
| if op.Transaction.Equals(candidate.ID) { | ||
| tx = candidate | ||
| txnIDStr = candidate.ID.String() | ||
| idempotencyKeyStr = string(candidate.IdempotencyKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW incase anyone else looks at this, IdempotencyKey is not a pointer just a string type so safe to cast to string
|
E2E has failed because the test WS disconnect from FireFly second instance and didn't receive the token_pool_confirmed event Created issue for it #1712 |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
|
E2E was failing due to the following which is explained by |
Proposed changes
Add eyecatcher logs such as the following, that can be used as anchors for diagnosing transaction paths.
Particularly for
blockchain_invoketransactions, it is important to see when the transaction came in, and correlate that with the connector for the plugin. This means correlating theidempotencyKey(app identifier),transactionId(overall FireFly transaction ID) andoperationId(unique ID used with the blockchain connector).