Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first step of FireFly Transaction Manager support - separate URL for submit #751

Merged
merged 11 commits into from
Apr 30, 2022

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Apr 21, 2022

  • Adds Hard Hat config for help deploying the FireFly batch pin contract to public chains
  • Allows an extra fftm config section alongside ethconnect in the ethereum config
    • Currently only used for SendTransaction when set (FFTM doesn't do events ... yet)
  • Allows you to specify a fromBlock for the ethconnect event listener for the batch pin contract

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #751 (c68b587) into main (fab9e31) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #751      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         323       323              
  Lines       20181     20191      +10     
===========================================
+ Hits        20178     20191      +13     
+ Misses          2         0       -2     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
internal/blockchain/ethereum/config.go 100.00% <100.00%> (ø)
internal/blockchain/ethereum/ethereum.go 100.00% <100.00%> (ø)
internal/blockchain/ethereum/eventstream.go 100.00% <100.00%> (ø)
pkg/wsclient/wsclient.go 100.00% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab9e31...c68b587. Read the comment docs.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst marked this pull request as ready for review April 30, 2022 05:27
@peterbroadhurst peterbroadhurst merged commit d361cb5 into hyperledger:main Apr 30, 2022
@peterbroadhurst peterbroadhurst deleted the fftm branch April 30, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants