Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-definition items from DefinitionHandler #789

Merged
merged 5 commits into from
May 3, 2022
Merged

Remove non-definition items from DefinitionHandler #789

merged 5 commits into from
May 3, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented May 3, 2022

Resolves #614

awrichar added 3 commits May 3, 2022 14:41
@awrichar
Remove privatemessaging wrappers from definitionhandler
f897180 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Move SendReply from definition_handler to event_dispatcher
44836df 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Rename DefinitionHandlers to DefinitionHandler
335f4c6 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar requested a review from shorsher May 3, 2022 18:50
awrichar added 2 commits May 3, 2022 15:02
@awrichar
Remove unneeded dependencies from DefinitionHandler
8a53577 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Check inputs to NewDefinitionHandler
c567b89 
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
peterbroadhurst
peterbroadhurst approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for the original split out didn't come back to me while doing the review 🤷
This is much cleaner.

@peterbroadhurst peterbroadhurst merged commit 7c5164a into hyperledger:main May 3, 2022
@peterbroadhurst peterbroadhurst deleted the definitions branch May 3, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes

@nguyer nguyer Awaiting requested review from nguyer

@shorsher shorsher Awaiting requested review from shorsher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename or split up DefinitionHandlers
2 participants
@awrichar @peterbroadhurst