Add language tag to FFM, FFE, FFC, etc #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
reviewed
May 19, 2022
awrichar
reviewed
May 19, 2022
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
approved these changes
May 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
===========================================
- Coverage 100.00% 99.97% -0.03%
===========================================
Files 304 304
Lines 18960 18958 -2
===========================================
- Hits 18960 18954 -6
- Misses 0 4 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on hyperledger/firefly-common#7 and a new release of
firefly-common.This adds the AmericanEnglish language tag to each of our existing message keys. These will be used as fallbacks if a specific key is missing in another language.
For now, this does not actually create multi-lingual documentation, but it lays the groundwork for it. I need to do some separate work in the docs generation to separate out pages for each language. That will be in a separate PR.