Namespace config validation #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorsher
requested review from
peterbroadhurst,
nguyer,
awrichar and
nickgaski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 299 299
Lines 19457 19551 +94
===========================================
+ Hits 19455 19551 +96
+ Misses 1 0 -1
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
* `name` must be unique on this node * for historical reasons, "ff_system" is a reserved string and cannot be used as a `name` or `remoteName` * a `database` plugin is required for every namespace * if `mode: multiparty` is specified, plugins _must_ include one each of `blockchain`, `dataexchange`, and `sharedstorage` * if `mode: gateway` is speicified, plugins _must not_ include `dataexchange` or `sharedstorage` * at most one of each type of plugin is allowed per namespace, except for tokens (which may have many per namespace) Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
awrichar
reviewed
May 24, 2022
awrichar
reviewed
May 24, 2022
awrichar
reviewed
May 24, 2022
awrichar
reviewed
May 24, 2022
awrichar
reviewed
May 24, 2022
awrichar
reviewed
May 24, 2022
|
It's worth calling out explicitly that this is config validation only - none of the newly added config is actually functional yet (which is fine for now). Also, I don't see that this bullet is enforced yet for the plugins:
It might be on orchestrator to enforce that before passing the list of plugins to Namespace Manager... |
|
Thanks for the comments and added some new changes which rely on your changes in hyperledger/firefly-common#14 |
awrichar
reviewed
May 25, 2022
awrichar
reviewed
May 25, 2022
awrichar
reviewed
May 26, 2022
awrichar
reviewed
May 26, 2022
awrichar
reviewed
May 26, 2022
awrichar
reviewed
May 26, 2022
awrichar
reviewed
May 26, 2022
awrichar
approved these changes
May 26, 2022
- Plugins names must be globally unique - Better handling of deprecated config in namespace manager - Updated config descriptions Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional configuration validation to the namespace manager, as specified in FIR-12
namemust be unique on this nodenameorremoteNamedatabaseplugin is required for every namespacemode: multipartyis specified, plugins must include one each ofblockchain,dataexchange, andsharedstoragemode: gatewayis speicified, plugins must not includedataexchangeorsharedstoragemay have many per namespace)
depends on changes in hyperledger/firefly-common#14