Enable non-multiparty namespaces #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
nickgaski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 99.96% 99.97% +0.01%
==========================================
Files 299 302 +3
Lines 19500 19650 +150
==========================================
+ Hits 19494 19646 +152
+ Misses 5 4 -1
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
awrichar
force-pushed
the
definitions2
branch
4 times, most recently
from
f988a66
to
1322d87
Compare
awrichar
changed the title
… Sender Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
If multiparty mode is disabled for a given namespace, do not initialize the multipary manager or any of the messaging managers. Adjust other components and routes to deal with these managers potentially being nil. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Due to spf13/viper#1386, array keys with mixed case are not parsed correctly. At least for the time being, mitigate by changing some keys to all lowercase. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
To align with other components, Definition Sender is the entry point for initiating the creation of contract FFIs/APIs, but it calls out to Contract Manager for validation. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
No need to create a message in this case. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Avoid starting plugins more than once. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
changed the title
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
shorsher
approved these changes
Jul 6, 2022
| @@ -44,7 +44,7 @@ func InitConfig(config config.ArraySection) { | |||
| } | |||
|
|
|||
| func InitConfigDeprecated(config config.Section) { | |||
| config.AddKnownKey(coreconfig.PluginConfigType, NewFFDXPluginName) | |||
| config.AddKnownKey(coreconfig.PluginConfigType) | |||
There was a problem hiding this comment.
Just making a note we might want to log or track somewhere that there is no longer a default. Migration guide 😃
There was a problem hiding this comment.
Yea, I tagged this PR with "migration consideration" in the hopes that one of us remembers why. Thankfully the CLI has explicitly populated "type" for a while (since hyperledger/firefly-cli#156). However, we will want to cut a 1.0.x patch release that includes #882, and recommend upgrading to that and fixing all config warnings as part of the migration journey to 1.1.
| @@ -700,7 +730,7 @@ func (nm *namespaceManager) loadNamespace(ctx context.Context, name string, inde | |||
| config.Multiparty.Contracts = contracts | |||
| p, err = nm.validateMultiPartyConfig(ctx, name, plugins) | |||
| } else { | |||
| p, err = nm.validateGatewayConfig(ctx, name, plugins) | |||
| p, err = nm.validateNonMultipartyConfig(ctx, name, plugins) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of FIR-12.
definitionspackage (so it now has the definition "senders" alongside the definition "handlers"). When multiparty is disabled, the senders call directly to the matched handlers without an intermediate broadcast message.Potential migration-breaking change: the deprecated
dataexchange.typekey no longer has a default offfdx. Older config files that omitted this key will fail to parse. See #882.