Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove namespace from sender_contracts #903

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

shorsher
Copy link
Member

@shorsher shorsher commented Jul 14, 2022

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #903 (865dfe3) into main (995d53b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main     #903    +/-   ##
========================================
  Coverage   99.96%   99.97%            
========================================
  Files         298      297     -1     
  Lines       19563    19398   -165     
========================================
- Hits        19557    19393   -164     
+ Misses          5        4     -1     
  Partials        1        1            
Impacted Files Coverage Δ
internal/definitions/sender_contracts.go 100.00% <ø> (ø)
cmd/firefly.go 100.00% <0.00%> (ø)
pkg/core/event.go 100.00% <0.00%> (ø)
pkg/core/namespace.go 100.00% <0.00%> (ø)
internal/data/data_manager.go 100.00% <0.00%> (ø)
internal/namespace/manager.go 100.00% <0.00%> (ø)
internal/definitions/sender.go 100.00% <0.00%> (ø)
internal/multiparty/manager.go 100.00% <0.00%> (ø)
internal/definitions/handler.go 100.00% <0.00%> (ø)
internal/orchestrator/status.go 100.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

go.sum Outdated Show resolved Hide resolved
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher merged commit 1486b27 into hyperledger:main Jul 26, 2022
@shorsher shorsher deleted the ns-checks branch July 26, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants