Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for connecting firefly to a remote fabric chaincode #908

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Conversation

web3dev6
Copy link
Contributor

Signed-off-by: Sarthak Joshi sarthakjoshi.in@gmail.com

Signed-off-by: Sarthak Joshi <sarthakjoshi.in@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #908 (92ef893) into main (ce9d5a5) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 92ef893 differs from pull request most recent head 1df558e. Consider uploading reports for the commit 1df558e to get more accurate results

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.02%     
==========================================
  Files         297      297              
  Lines       19400    19400              
==========================================
- Hits        19397    19395       -2     
- Misses          3        4       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
internal/tokens/fftokens/fftokens.go 99.56% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing this, @satoshi-u! This is really useful and I definitely think it will help other people who want to do the same thing. I have a few suggestions for minor changes and then I would love to get this merged.

docs/tutorials/fabric_remote.md Outdated Show resolved Hide resolved
docs/tutorials/fabric_remote.md Outdated Show resolved Hide resolved
docs/tutorials/fabric_remote.md Outdated Show resolved Hide resolved
web3dev6 and others added 2 commits July 22, 2022 13:39
Co-authored-by: Nicko Guyer <nguyer@users.noreply.github.com>
Signed-off-by: Sarthak Joshi <49374672+satoshi-u@users.noreply.github.com>
Signed-off-by: Sarthak Joshi <sarthakjoshi.in@gmail.com>
@web3dev6
Copy link
Contributor Author

Thank you very much for contributing this, @satoshi-u! This is really useful and I definitely think it will help other people who want to do the same thing. I have a few suggestions for minor changes and then I would love to get this merged.

Happy to contribute! I have incorporated your suggestions in my PR. Thanks!

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just one thing to fix with the relative links, then I'm happy to merge.

docs/tutorials/fabric_remote.md Outdated Show resolved Hide resolved
docs/tutorials/fabric_remote.md Outdated Show resolved Hide resolved
Signed-off-by: Sarthak Joshi <sarthak@settlemint.com>
@web3dev6
Copy link
Contributor Author

This looks good! Just one thing to fix with the relative links, then I'm happy to merge.

done.

@nguyer nguyer merged commit 5bb8f4c into hyperledger:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants