-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added documentation for connecting firefly to a remote fabric chaincode #908
Conversation
Signed-off-by: Sarthak Joshi <sarthakjoshi.in@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 99.98% 99.97% -0.02%
==========================================
Files 297 297
Lines 19400 19400
==========================================
- Hits 19397 19395 -2
- Misses 3 4 +1
- Partials 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing this, @satoshi-u! This is really useful and I definitely think it will help other people who want to do the same thing. I have a few suggestions for minor changes and then I would love to get this merged.
Co-authored-by: Nicko Guyer <nguyer@users.noreply.github.com> Signed-off-by: Sarthak Joshi <49374672+satoshi-u@users.noreply.github.com>
Signed-off-by: Sarthak Joshi <sarthakjoshi.in@gmail.com>
Happy to contribute! I have incorporated your suggestions in my PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just one thing to fix with the relative links, then I'm happy to merge.
Signed-off-by: Sarthak Joshi <sarthak@settlemint.com>
done. |
Signed-off-by: Sarthak Joshi sarthakjoshi.in@gmail.com