Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for EVMConnect support (with EthConnect cross-compatibility) #923

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

peterbroadhurst
Copy link
Contributor

  • Support the TransactionUpdate type of websocket payload - which just updates the operation, while leaving it in Pending status (rather than marking it success/fail)
  • Support events with an 0x12345: address prefix on the signature

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #923 (d1cff97) into main (3ae7ba8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         299      299           
  Lines       19475    19483    +8     
=======================================
+ Hits        19470    19478    +8     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
internal/blockchain/ethereum/ethereum.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@nguyer nguyer merged commit 15cf5f9 into hyperledger:main Aug 8, 2022
@nguyer nguyer deleted the evm branch August 8, 2022 12:51
@peterbroadhurst peterbroadhurst restored the evm branch August 9, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants