Fix bugs with Operations (and other minor fixes) #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awrichar
commented
Aug 5, 2022
•
awrichar
commented
- Always populate Operation namespace from Managers instead of from other objects
- Actually store pending blob upload Operations
- Other misc cleanup identified while doing E2E and perf test runs
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Set defaults with bash parameter expansion. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
The in-flight data items don't always have namespace populated, but Managers now always know the namespace to which they are assigned. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 299 299
Lines 19465 19478 +13
=======================================
+ Hits 19460 19473 +13
Misses 4 4
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shorsher
approved these changes
Aug 8, 2022
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
changed the title
awrichar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.