Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise full node name (with suffix) to DX #942

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Aug 8, 2022

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #942 (797da9f) into main (e22d84a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.02%     
==========================================
  Files         299      299              
  Lines       19478    19481       +3     
==========================================
+ Hits        19475    19476       +1     
- Misses          3        4       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
internal/dataexchange/ffdx/ffdx.go 100.00% <100.00%> (ø)
internal/tokens/fftokens/fftokens.go 99.53% <0.00%> (-0.47%) ⬇️
internal/events/aggregator.go 100.00% <0.00%> (ø)
internal/namespace/manager.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awrichar
Copy link
Contributor Author

awrichar commented Aug 9, 2022

This is failing because the DX node doesn't trust its own cert (when sending messages to itself).

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit bd53159 into hyperledger:main Aug 10, 2022
@awrichar awrichar deleted the dxdestination branch August 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants