Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimistic inserts for blockchain events #977

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

awrichar
Copy link
Contributor

Always attempt to insert first, then fall back to a query for duplicates.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #977 (ad5cff2) into main (b8556a4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ad5cff2 differs from pull request most recent head 0e55946. Consider uploading reports for the commit 0e55946 to get more accurate results

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   99.99%   99.98%   -0.02%     
==========================================
  Files         299      299              
  Lines       19581    19588       +7     
==========================================
+ Hits        19580    19585       +5     
- Misses          1        2       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
...nternal/database/sqlcommon/blockchainevents_sql.go 100.00% <100.00%> (ø)
internal/events/blockchain_event.go 100.00% <100.00%> (ø)
internal/orchestrator/data_query.go 100.00% <100.00%> (ø)
internal/txcommon/txcommon.go 100.00% <100.00%> (ø)
internal/apiserver/server.go 99.12% <0.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Always attempt to insert first, then fall back to a query for duplicates.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@shorsher shorsher merged commit cec7b98 into hyperledger:main Aug 18, 2022
@shorsher shorsher deleted the events branch August 18, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants