Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore camelCase key names #988

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Restore camelCase key names #988

merged 1 commit into from
Aug 19, 2022

Conversation

awrichar
Copy link
Contributor

Since the Viper patch has been absorbed (#930), it's OK to use
camelCase in config files again.

Since the Viper patch has been absorbed, it's OK to use
camelCase in config files again.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #988 (b867abc) into main (d23766c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   99.99%   99.98%   -0.02%     
==========================================
  Files         301      301              
  Lines       19800    19800              
==========================================
- Hits        19799    19797       -2     
- Misses          1        2       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
internal/coreconfig/coreconfig.go 100.00% <ø> (ø)
internal/identity/identitymanager.go 100.00% <ø> (ø)
internal/apiserver/server.go 99.12% <0.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 🐫

@awrichar awrichar merged commit de314c8 into hyperledger:main Aug 19, 2022
@awrichar awrichar deleted the config branch August 19, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants