-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose HIPE: Error reporting #65
Conversation
Signed-off-by: Stephen Curran <swcuran@gmail.com>
Signed-off-by: Stephen Curran <swcuran@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
minor tweaks to make some verbiage clearer
Signed-off-by: Stephen Curran <swcurran@gmail.com>
text/error-handling/README.md
Outdated
} | ||
``` | ||
|
||
### Fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting the field list into Required Fields and Optional Fields would make the flexibility of this message type more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TelegramSam - not clear on how you would split it. Could you please expound? We presumably wouldn't want "required" and "optional" JSON objects. Or is that the suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, just splitting up the list in the documentation. No actual changes to the JSON at all.
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
I feel like there should be an error code field. There is a code for the human-readable error, but not necessarily a top-level attribute with a code that can be specified in a message family and matched when processing the error message. |
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
This is now superseded by Aries RFC 0035: hyperledger/aries-rfcs#35 |
A HIPE that proposes a new message type ("problem-report") for handling some categories of errors, and provides recommendations on the handling of a broad range of error categories, including the timeouts.