-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds GitHub Actions and build containers #1648
Conversation
Signed-off-by: Kevin Griffin <griffin.kev@gmail.com>
RUN apt-get update -y && apt-get install -y \ | ||
python3-nacl \ | ||
libindy-crypto=0.4.5 \ | ||
libindy=1.13.0~1420 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: bump to 1.15.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Toktar, @m00sey did try this, but it caused errors in Jenkins build; #1645 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I suggest bumping libindy and libindy's wrapper to the last master because it's a bad idea to have different versions. But we can do it in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WadeBarnes How can it affect Jenkins? Maybe this version is just missing in the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely, I was going off the related Jenkins build error from this change; #1645 (comment). But I see they are separate docker files now.
(ci) test this please. |
(ci) test this please |
RUN apt-get update -y && apt-get install -y \ | ||
python3-nacl \ | ||
libindy-crypto=0.4.5 \ | ||
libindy=1.13.0~1420 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WadeBarnes How can it affect Jenkins? Maybe this version is just missing in the repository?
No description provided.